Repository navigation
Treat CGKA ops as pending until all cited certificates are in doc's closure - #329
Merged
Merged
Conversation
expede
approved these changes
Nov 4, 2026
expede
left a comment
expede
left a comment
Member
There was a problem hiding this comment.
Seems straightforward 👍
Nit from the bot:
The new check makes record_citations partly redundant. closure returns certificates from the store, so if every citation is in the closure, the store has all of them, and record_citations can no longer return false. Two consequences:
- The current order (record_citations(op) || cites_only_closure(op)) first writes the foreign certificate into the shared certificates.cited table, then parks the op as pending forever.
- Checking the closure first fixes that. record_citations then only fills the cache, and its Pending branch can't be reached.
Not a blocker, but figured I'd mention it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was possible to cite the wrong things and force an op to be authorized as a result. This ensures all must be in the doc's closure locally.